Edit AllPages

My program has several calls to -[NSMenu addItemWithTitle:action:keyEquivalent:]. I’m invoking this method on a NSMenu variable “menu.”

Each time that my program makes a call such as (note that “temp” is a NSString):

[menu addItemWithTitle:temp action:nil keyEquivalent:@””];

XCode (gcc) report the following warning for each place I invoke the method call:

MEController.m:1192: warning: assignment from incompatible pointer type

Why? How can I get rid of this warning (without disabling warnings :-))?

Thanks in advance, Joe

Are you certain that “temp” is a pointer to an NSString? It’s not a C string or anything else? (didn’t forget the “@” symbol somewhere?)

Here’s the assigment of temp:

NSString *temp = NSLocalizedString(@”Controls”,@””);

And while I’m at it…

menu = [[NSMenu alloc] init];

And the program seems to work correctly. I don’t have any troubles with any of the menus (I get this error for submenus of “menu” as well). I just wish I could have clean build output.

Strange, I don’t get any warnings with this code.

NSString *temp = @”Hello World!”; NSMenu *menu = [[NSMenu alloc] init];

[menu addItemWithTitle:temp action:nil keyEquivalent:@””];

Perhaps you should try cleaning the target and rebuilding. – RyanBates

Are you assigning the returned NSMenuItem to a NSMenuItem *? That might be what it is, it should be id now.

I’m betting it’s setting your action to nil that’s doing it; it’s expecting a SEL and you’re handing it an id. Try setting it to NULL instead. – Bo

PS Or wait, it worked for Ryan; Now I am confused. Maybe you should post, say, the whole code fragment where the errors are occurring.

Thanks for your response. Here’s a typical example:

NSMenuItem *theCityItem; theCityItem = [menu addItemWithTitle:[NSString stringWithFormat:@”%@ %@”,weatherFor,[city cityName]] action:@selector(dummy:) keyEquivalent:@””];

It seems like my error may be caused by the suggested NSMenuItem * vs. id .

What’s the proper way to handle something like this? If you could give me a warning-free example, that’d be great!

Many thanks, Joe

Try just coercing it to the right type, i.e. theCityItem = (NSMenuItem*)[menu addItemWithTitle:blah action:blah keyEquivalent:blahblah];. I generally allocate menu items directly and then add them to the menu once they’re set up, so I haven’t seen this. – Bo.

I do this:

id theCityItem; theCityItem = [menu addItemWithTitle:[NSString stringWithFormat:@"%@ %@",weatherFor,[city cityName]] action:@selector(dummy:) keyEquivalent:@""];

Of course, Apple on says (and have been for a long time):

*The NSMenuItem protocol is being removed from the Application Kit; you must use the NSMenuItem class instead. This change does not affect binary compatibility between different versions of projects, but might cause failures in project builds. To adapt your projects to this change, alter all references to the protocol (for example, �id �) to references to the class (�NSMenuItem�).*

But nothing really seems to have neen done about this. All new menu API they public still uses id -- they could easily change it to NSMenuItem* as they say it won't affect binary compatibility...but who knows.